Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36361 )
Change subject: soc/intel/icelake: Don't save tolum_base to ebda ......................................................................
soc/intel/icelake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: Ib39d495262758fa884b5940a8deb7d2a34b2c498 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/icelake/memmap.c 1 file changed, 2 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/36361/1
diff --git a/src/soc/intel/icelake/memmap.c b/src/soc/intel/icelake/memmap.c index d8cdb56..3b42801 100644 --- a/src/soc/intel/icelake/memmap.c +++ b/src/soc/intel/icelake/memmap.c @@ -14,7 +14,6 @@ */
#include <arch/romstage.h> -#include <arch/ebda.h> #include <cbmem.h> #include <console/console.h> #include <cpu/x86/mtrr.h> @@ -22,7 +21,6 @@ #include <device/device.h> #include <device/pci.h> #include <fsp/util.h> -#include <intelblocks/ebda.h> #include <intelblocks/systemagent.h> #include <soc/pci_devs.h> #include <soc/soc_chip.h> @@ -183,28 +181,11 @@ dram_base -= calculate_traditional_mem_size(dram_base, dev);
/* Get Intel Reserved Memory Range Size */ - *reserved_mem_size = calculate_reserved_mem_size(dram_base, dev); - - dram_base -= *reserved_mem_size; + dram_base = calculate_reserved_mem_size(dram_base, dev);
return dram_base; }
-/* Fill up memory layout information */ -void fill_soc_memmap_ebda(struct ebda_config *cfg) -{ - size_t chipset_mem_size; - - cfg->tolum_base = calculate_dram_base(&chipset_mem_size); - cfg->reserved_mem_size = chipset_mem_size; -} - -void cbmem_top_init(void) -{ - /* Fill up EBDA area */ - fill_ebda_area(); -} - /* * +-------------------------+ Top of RAM (aligned) * | System Management Mode | @@ -234,8 +215,6 @@ */ void *cbmem_top_romstage(void) { - struct ebda_config ebda_cfg; - /* * Check if Tseg has been initialized, we will use this as a flag * to check if the MRC is done, and only then continue to read the @@ -244,10 +223,7 @@ */ if (sa_get_tseg_base() == 0) return NULL; - - retrieve_ebda_object(&ebda_cfg); - - return (void *)(uintptr_t)ebda_cfg.tolum_base; + return (void *)calculate_dram_base(); }
void fill_postcar_frame(struct postcar_frame *pcf)