Attention is currently required from: Mac Chiang, Pranava Y N, Weimin Wu.
Subrata Banik has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/soundwire: Support Realtek ALC712 codec
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85571/comment/64fe00e9_aed55513?usp... :
PS2, Line 13: static struct soundwire_multilane alc711_multilane = {
: };
Because I don't know how the default value should be configured, and if the chip config does not provide data, then because lane_mapping_count and lane_bus_holder_count are 0, no extra data will be generated, except that one more soundwire_gen_interface_revision(dsd) will be generated. To be honest, I am not sure whether it will cause interference, these need to be confirmed by actual debugging on the board.
can Varun (Intel) able to share a response about how to handle the default data ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85571?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib79896a9fe23f2f66d6ee3a24f5a62bfa0f7a649
Gerrit-Change-Number: 85571
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 08:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Weimin Wu
wuweimin@huaqin.corp-partner.google.com