Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46949 )
Change subject: soc/intel/broadwell: Use Haswell CPU headers ......................................................................
Patch Set 15: Code-Review+2
(1 comment)
File src/cpu/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/46949/comment/0411e908_ec6b6cc1 PS15, Line 173: /* CPU identification */ : static inline u32 cpu_family_model(void) : { : return cpuid_eax(1) & 0x0fff0ff0; : } : : static inline u32 cpu_stepping(void) : { : return cpuid_eax(1) & 0xf; : }
I would move them to cpu/intel/common but these may not work for model F CPUs
Can we leverage get_fms into some static inlines to get model, family and stepping? Let's however not delay this patchtrain because of this.