Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )
Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards ......................................................................
Patch Set 28:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/... File util/spd_tools/intel/ddr4/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/... PS28, Line 476: tRRDLFromTck = 4 * memAttribs.TCKMinPs : : if tRRDLFixed < tRRDLFromTck { : return tRRDLFromTck : } else { : return tRRDLFixed : } :
Technically, I think this should go into the updateTRRDLMin() to make sure that if a user specified […]
Yeah I think if there is an override present, we will want to honor that. I am fine if you want to move this to updateTRRDLMin() to ensure that the json file does not have mistakes. And if there really arises a situation where we have to ignore the formula, we can update the tool.
https://review.coreboot.org/c/coreboot/+/44429/11/util/spd_tools/intel/ddr4/... File util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/44429/11/util/spd_tools/intel/ddr4/... PS11, Line 15: 9 10 11 12 13 14 15 16 17 19 19 20
The speed bin 3200AA is SUPPOSED to support 9 thru 22 and 24. […]
Are you referring to the line "Programmable CAS latency 9, 10... and 20 supported". I think there is something missing. From the table "Operating Frequency" I see that there are different grades for the same part name. I am not sure if the above sentence really applies to -XN part. Also pages 37 onwards, it covers the "Standard Speed Bins" where in 3200 22-22-22 seems to support all the CLs as outlined by JEDEC spec.
Can you please get a confirmation from Catherine and/or ODM to ensure what CLs are really supported? I also checked the sample SPDs provided by ODM here: https://b.corp.google.com/issues/161772961#comment16 and it looks like at least both Hynix parts here support all the standard CLs for 3200 22-22-22 grade.