Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45568 )
Change subject: drivers/tpm: Implement full PPI ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45568/5/src/commonlib/include/commo... File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/45568/5/src/commonlib/include/commo... PS5, Line 89:
spurious newline?
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/Kconfig File src/drivers/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/Kconfig@10 PS5, Line 10: TPM: Generate ACPI code for physical presence interface
Instead of having a TPM prefix, how about: […]
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/Kconfig@17 PS5, Line 17: Tcg
TCG
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/Kconfig@17 PS5, Line 17: Stub
stub
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/ppi.c File src/drivers/tpm/ppi.c:
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/ppi.c@41 PS5, Line 41: OS
OSes
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/ppi.c@42 PS5, Line 42: Tcg
TCG
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/ppi.c@563 PS5, Line 563: printk(BIOS_DEBUG, "PPI: Pending OS request: 0x%x (0x%x)\n", ppib->pprq, ppib->pprm);
Since the else-branch returns, you can invert the if-else branches (and invert the condition), then […]
Done
https://review.coreboot.org/c/coreboot/+/45568/5/src/drivers/tpm/ppi.c@726 PS5, Line 726: tpm_ppi->ppi_version = BCD(1, 3);
Shouldn't this match what `tpm_ppi_func1_cb` returns?
That's the version of the PPI used to generate the ACPI functions. It always generates all functions compatible to 1.3.