31 Jan
2022
31 Jan
'22
9:57 a.m.
Attention is currently required from: Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61430 )
Change subject: soc/intel/common/cse: Make cse_disable_mei_devices a public function ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/61430/comment/c956b9d5_52c52b3b PS3, Line 489: Function to make cse disable
Sorry, I don't think there is anything grammatically wrong here. […]
I'm not hard on my comment, but the most comments are imperative statements.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61430
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2a1eb2fdc9d4724bd287b82be4238893c967046
Gerrit-Change-Number: 61430
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 31 Jan 2022 09:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-MessageType: comment