Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33362 )
Change subject: vendorcode/agesa/{f12,f14,f15tn,f16kb}/GNB/Modules: Fix check for valid PhyLane
......................................................................
Patch Set 5:
(1 comment)
Please fix the commit summary (usual limit is 55 chars,
72 should be the absolute maximum).
https://review.coreboot.org/#/c/33362/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33362/5//COMMIT_MSG@7
PS5, Line 7: vendorcode/agesa
`vendorcode/agesa:` would be enough for the prefix, I guess
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia04ac5b1d0a4434c0ab2ca583b9b03dbfd0ffd41
Gerrit-Change-Number: 33362
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 15 Jun 2019 16:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment