Attention is currently required from: Paul Fagerburg, Julius Werner, Jan Dabros, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58163 )
Change subject: tests: Fix JUNIT_OUTPUT=y to write to files instead of stderr
......................................................................
Patch Set 2:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58163/comment/ca398225_3295212e
PS2, Line 232: rm -f $(testobj)/junit-$(subst /,_,$(patsubst $(testobj)/%/,%,$(dir $^)))(*).xml
would `rm -f $(testobj)/junit-*. […]
It could work, but $^ here refers to $$($$(@)-bin). We do not want to remove junit files of other tests. Am I right?
https://review.coreboot.org/c/coreboot/+/58163/comment/62e9062d_632d264f
PS2, Line 233: rm -f $(testobj)/$(subst /,_,$^).failed
would `rm -f ${testobj)/*. […]
Same as above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58163
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09891aca923bf1271cafeaa09f89b6539022709c
Gerrit-Change-Number: 58163
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 07 Oct 2021 16:49:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment