Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31239 )
Change subject: commonlib/loglevel.h: Drop unnecessary include
......................................................................
Patch Set 7: Code-Review+1
Maybe make it explicit and place a comment above the include
in `console.h`, e.g.
/* console.h is supposed to provide the log levels defined in here: */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief61106eb78d0de743c920f358937c51658c228a
Gerrit-Change-Number: 31239
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Mar 2019 11:54:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment