Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42919 )
Change subject: [RFC] supermicro/x11-lga1151/gpio: 5/5 Remap reset sources ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
No, it should and shall not change the way they function but just convert the ugly raw values to human-readable macros.
so the output from `inteltool -g` is identical before/after the patchset?
No, the dump of the DW0 and DW1 registers is different before and after the patches. To convert raw values to macros, we should ignore some bit fields. For example, RX/TX Buf Disable DW0[9:8] doesn't affect the pad in native function mode (intel doc #549921) and the PAD_CFG_NF macros don't take them into account (the value is set to 0). I change the values of the DW registers in separate patches:
CB:42917 - 2/5 Exclude fields for PAD_CFG CB:42918 - 3/5 Fixes some field macro
Thus, it is easier to find a mistake or do revert to a patch in order to repeat the testing. This is @Angel’s idea (This helped me fix some bugs in the utility. Good idea, thanks).
Similarly done for up board (Apollo Lake):
CB:42608 - 1/3 Decode raw register values CB:42915 - 2/3 Exclude fields that are not in PAD_CFG* CB:39765 - 3/3 Converts bit field macros to PAD_CFG
The last 5/5 patch isn't correct, as the reset source remapping is already applied in the configuration with raw values DW0 and DW1.
Well, yes, the raw values differ but that does not change "the way they [the GPIOs] function", which is exactly the reaso *why* those bits can be ignored :-)