[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/corsola: Make compatible with MT8186T by modifing skuid

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )

Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84342/comment/e33e06d6_120d1655?usp... :
PS2, Line 7: Make compatible with MT8186T by modifing skuid
Distinguish MT8186T's SKU ID from MT8186

https://review.coreboot.org/c/coreboot/+/84342/comment/cf380fb8_c4b822c1?usp... :
PS2, Line 9: skuid
SKU ID

https://review.coreboot.org/c/coreboot/+/84342/comment/b943c8d6_1f0e4569?usp... :
PS2, Line 11: coreboot will pass skuid to kernel by 0x7ffffffe,
            : so kernel can get the corresponded dts file for system boot.
change the SKU ID to 0x7ffffffe, so that the correct dts file will be selected by the payload.

File src/mainboard/google/corsola/boardid.c:

https://review.coreboot.org/c/coreboot/+/84342/comment/358ad979_dfe75eb8?usp... :
PS2, Line 16: /* Define compatible sku_id value */
remove

https://review.coreboot.org/c/coreboot/+/84342/comment/23be00ba_ae9c647f?usp... :
PS2, Line 17: CROS_SKU_COM
CROS_SKU_UNPROVISIONED_MT8186T

https://review.coreboot.org/c/coreboot/+/84342/comment/d0bcb5c5_e3364144?usp... :
PS2, Line 132: BOARD_GOOGLE_STEELIX
The 0x7FFFFFFE value should be applied to all MT8186T boards, not just steelix. Please rewrite the code as:

```
if (cached_sku_code == CROS_SKU_UNPROVISIONED) {
    printk(BIOS_WARNING, "Unprovisioned SKU code from EC: %s\n");
    if (get_cpu_id() == MTK_CPU_ID_MT8186T) {
        /* Distinguish MT8186T from MT8186 to select different device trees
           in the payload. */
        cached_sku_code = CROS_SKU_UNPROVISIONED_MT8186T;
    } else if (CONFIG(BOARD_GOOGLE_STARYU_COMMON)) {
        /* Reserve last 4 bits to report PANEL_ID */
        cached_sku_code = 0x7FFFFFF0UL | panel_id();
    }
} else if (cached_sku_code == CROS_SKU_UNKNOWN) {
    printk(BIOS_WARNING, "Failed to get SKU code from EC\n");
    cached_sku_code = (get_adc_index...
}
```