Attention is currently required from: Anand Vaikar, Fred Reitberger, Jason Glenesk.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman: Add Birmanplus board support for PHX1 SOC ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80353/comment/8225cbd7_0160882f : PS2, Line 7: PHX1 What does the 1 refer to?
https://review.coreboot.org/c/coreboot/+/80353/comment/bbc6e82f_921a71f3 : PS2, Line 7: Birmanplus What is the official spelling?
https://review.coreboot.org/c/coreboot/+/80353/comment/84d23c29_0e670130 : PS2, Line 9: 1)Initial commit for upstreaming Birmanplus mainboard changes. What does the *plus* mean?
https://review.coreboot.org/c/coreboot/+/80353/comment/f756f8d0_72ff91d3 : PS2, Line 9: 1)Initial commit for upstreaming Birmanplus mainboard changes. : 2)Add the DXIO descriptors for Birmanplus mainboard. Please add a space after the item “bullet”. Though reading the items, it’s not really an enumeration.
Patchset:
PS2: t