build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31603 )
Change subject: mainboard: Add ASRock H110M-DVS ......................................................................
Patch Set 2:
(23 comments)
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/bootblock... File src/mainboard/asrock/h110m/bootblock.c:
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/bootblock... PS2, Line 26: const pnp_devfn_t serial_dev = PNP_DEV(0x2e, NCT6791D_SP1); code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/bootblock... PS2, Line 26: const pnp_devfn_t serial_dev = PNP_DEV(0x2e, NCT6791D_SP1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/bootblock... PS2, Line 27: nuvoton_enable_serial(serial_dev, CONFIG_TTYS0_BASE); code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/bootblock... PS2, Line 27: nuvoton_enable_serial(serial_dev, CONFIG_TTYS0_BASE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... File src/mainboard/asrock/h110m/variants/dvs/include/variant/gpio.h:
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 23: _PAD_CFG_STRUCT(val, config0, config1) code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 23: _PAD_CFG_STRUCT(val, config0, config1) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 41: H110_PAD_DW0_DW1_CFG(GPP_A13, 0x44000600, 0x00000025), /* SUSWARN#/SUSPWRDNACK */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 132: H110_PAD_DW0_DW1_CFG(GPP_E4, 0x84000500, 0x0000001c), /* SATA_DEVSLP0 */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 133: H110_PAD_DW0_DW1_CFG(GPP_E5, 0x84000500, 0x0000001d), /* SATA_DEVSLP1 */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 134: H110_PAD_DW0_DW1_CFG(GPP_E6, 0x84000500, 0x0000001e), /* SATA_DEVSLP2 */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 235: H110_PAD_DW0_DW1_CFG(GPP_I5, 0x84000500, 0x00000072), /* DDPB_CTRLCLK */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 236: H110_PAD_DW0_DW1_CFG(GPP_I6, 0x84000500, 0x00001073), /* DDPB_CTRLDATA */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 237: H110_PAD_DW0_DW1_CFG(GPP_I7, 0x84000500, 0x00000074), /* DDPC_CTRLCLK */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 238: H110_PAD_DW0_DW1_CFG(GPP_I8, 0x84000500, 0x00001075), /* DDPC_CTRLDATA */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 239: H110_PAD_DW0_DW1_CFG(GPP_I9, 0x84000500, 0x00000076), /* DDPD_CTRLCLK */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 240: H110_PAD_DW0_DW1_CFG(GPP_I10, 0x84000500, 0x00001077), /* DDPD_CTRLDATA */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 257: H110_PAD_DW0_DW1_CFG(GPP_A13, 0x44000600, 0x00000025), /* SUSWARN#/SUSPWRDNACK */ line over 80 characters
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 257: H110_PAD_DW0_DW1_CFG(GPP_A13, 0x44000600, 0x00000025), /* SUSWARN#/SUSPWRDNACK */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 257: H110_PAD_DW0_DW1_CFG(GPP_A13, 0x44000600, 0x00000025), /* SUSWARN#/SUSPWRDNACK */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 258: H110_PAD_DW0_DW1_CFG(GPP_A14, 0x44000600, 0x00000026), /* SUS_STAT# */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 258: H110_PAD_DW0_DW1_CFG(GPP_A14, 0x44000600, 0x00000026), /* SUS_STAT# */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 259: H110_PAD_DW0_DW1_CFG(GPP_A15, 0x44000502, 0x00003027), /* SUS_ACK# */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 259: H110_PAD_DW0_DW1_CFG(GPP_A15, 0x44000502, 0x00003027), /* SUS_ACK# */ please, no spaces at the start of a line