Attention is currently required from: Angel Pons, Felix Singer, Paul Menzel.
Ingo Reitz has posted comments on this change by Ingo Reitz. ( https://review.coreboot.org/c/coreboot/+/82943?usp=email )
Change subject: util/nixshell: add dependencies to nix devshell reqired by some payloads
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
That shouldn't be needed since the toolchain package includes GNAT. (...) […]
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/82943/comment/b5edc09f_42e00864?usp... :
PS1, Line 2: ninelore
Please use “Ingo Reitz”. […]
Done
https://review.coreboot.org/c/coreboot/+/82943/comment/0140cafa_d095873e?usp... :
PS1, Line 8:
It’d be great if you elaborated.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82943?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I880741567755712f4ab2c169a589d17bac491186
Gerrit-Change-Number: 82943
Gerrit-PatchSet: 2
Gerrit-Owner: Ingo Reitz
9l@9lo.re
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 22:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ingo Reitz
9l@9lo.re
