Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34487 )
Change subject: soc/intel/baytrail: Prevent unintended sign extensions
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34487/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34487/2//COMMIT_MSG@33
PS2, Line 33: Found-by: Coverity CID 1229{699,700,701,702}
I really like this syntax. But using the full syntax makes it easier to search with grep for it. Can you extend it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34487
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5db6001504cefb501dee199590a0e961a15771b
Gerrit-Change-Number: 34487
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 02:04:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment