Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41442 )
Change subject: device: Move resource allocation into a separate compilation unit ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@9 PS2, Line 9: alllocator
note: problem is that there are three `l` instead of two
Done
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@11 PS2, Line 11: resource_allocator_v3.c: This is the old implementation of : resource allocator that uses a single window for resource : allocation. It is required to support some AMD chipsets that do not : provide an accurate map of allocated resources by the time the : allocator runs. They work fine with the old allocator since it : restricts itself to allocations in a single window at the top of the : 4G space. : resource_allocator_common.c: This file contains the functions that can : be shared by the old and new resource allocator.
Please format that as a list.
Done
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@23 PS2, Line 23: RESOURCE_ALLOCATOR_V3
Out of curiosity, why is it called V3?
Based on git blame I could that this was v3 of the resource allocator. Hence, I picked the same name.
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@25 PS2, Line 25: enbaled
enabled
Done