Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48287 )
Change subject: soc/amd/picasso/tsc: fix clock divisor range check ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I'm OK with the change. However I'd convinced Nick to put it the way it was in CB:45055 in case a new did became unreserved, i.e. it looks like the reserved values are merely unused, not unsupportable. Since we're reading what's already in the register, I'd err on the side of interpreting it if possible. (And an error message is OK too.)
Since the corresponding else block prints an error and then continues with a safe fallback, I don't see this change becoming an issue in the future and if it does, we'll at least get a useful error message