10 Jul
2020
10 Jul
'20
1:45 p.m.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42976 )
Change subject: /mb/ocp/deltalake: Deselect POWER_STATE_DEFAULT_ON_AFTER_FAILURE ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42976/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/42976/4/src/mainboard/ocp/deltalake... PS4, Line 16: config MAINBOARD_POWER_FAILURE_STATE
This is supposed to be controlled by the user choice in the "Mainboard" […]
How about another option: Keep all Kconfig files intact, but update configs/builder/config.ocp.deltalake?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f14bdfc18740976171fd5d369b2d79a916dc4
Gerrit-Change-Number: 42976
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bryant Ou bryant.ou.q@gmail.com
Gerrit-CC: Frans Hendriks fhendriks@eltan.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-CC: Rocky Phagura
Gerrit-CC: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Comment-Date: Fri, 10 Jul 2020 16:45:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment