[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add device Ids for new CFL SKUs support

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )

Change subject: soc/intel/cannonlake: Add device Ids for new CFL SKUs support
......................................................................

Patch Set 17: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/34157/17//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34157/17//COMMIT_MSG@7 
PS17, Line 7: soc/intel/cannonlake: Add device Ids for new CFL SKUs support
> there is no WHL related DIDs added in this patch.

Only the names are aligned. Generally, that belongs in a separate
commit (even if it's merely about IDs, orthogonal changes can block
each other during review). But let's not stall this one further.

https://review.coreboot.org/c/coreboot/+/34157/17/src/include/device/pci_ids... 
File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/34157/17/src/include/device/pci_ids... 
PS17, Line 2733: #define PCI_DEVICE_ID_INTEL_CNP_H_LPC_C246	0xa309
It would be nice to keep these sorted by value (within their group). But
that doesn't seem to be a strict rule here.