Attention is currently required from: Jérémy Compostella.
Hello Jérémy Compostella,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/84216?usp=email
to review the following change.
Change subject: soc/intel/pantherlake: Hardcode IOM_BASE_ADDR_MAX value ......................................................................
soc/intel/pantherlake: Hardcode IOM_BASE_ADDR_MAX value
iasl refuses to perform an arithmetic computation in a QWordMemory parameter and fails with the following error.
dsdt.asl 2149: 0x4010800000, ((0x4010800000 + 0x10000) - 1), 0x0, Error 6051 - ^ Address Min is greater than Address Max
This commit replaces the arithmetic with the result to define IOM_BASE_ADDR_MAX.
BUG=b:348678529 TEST=Build for google/fatcat mainboard.
Change-Id: Ia5cf899b049cb8eb27b4ea30c7f3ce7a14884f16 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/soc/intel/pantherlake/include/soc/iomap.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/84216/1
diff --git a/src/soc/intel/pantherlake/include/soc/iomap.h b/src/soc/intel/pantherlake/include/soc/iomap.h index a98d550..86e5ec1 100644 --- a/src/soc/intel/pantherlake/include/soc/iomap.h +++ b/src/soc/intel/pantherlake/include/soc/iomap.h @@ -85,7 +85,7 @@ */ #define IOM_BASE_ADDR 0x4010800000 #define IOM_BASE_SIZE 0x10000 -#define IOM_BASE_ADDR_MAX ((IOM_BASE_ADDR + IOM_BASE_SIZE) - 1) +#define IOM_BASE_ADDR_MAX 0x401080ffff
/* I/O port address space */ #define ACPI_BASE_ADDRESS 0x1800