Attention is currently required from: Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80715?usp=email )
Change subject: amdfwtool: Use Makefile.mk for Makefile settings ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/80715/comment/484dbeab_1db27942 : PS2, Line 23: HEADER Should this be `$(amdfwheader)`?
File util/amdfwtool/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80715/comment/8db7c86d_3a863ffb : PS2, Line 26: $(top)/util/amdfwtool I think you could try to use `$(dir)` here instead of the full `$(top)/util/amdfwtool`. (`dir` is the loop variable in the top-level Makefile when the Makefile.mk gets included)