Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37306/25/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/25/src/mainboard/google/trogd... PS25, Line 59: qupv3_se_fw_load_and_init(QUPV3_1_SE1, SE_PROTOCOL_I2C, MIXED); /* Trackpad I2C */ Just noticed another problem here: coreboot will only link and run its UART driver when it is configured to do serial output (which we disable for production images). However, when we disable serial output in firmware, we may still want it in the kernel. So we need to manually load the QUP firmware for the UART here in that case. We need to insert something like this:
if (!CONFIG(CONSOLE_SERIAL)) /* When no coreboot serial, still need UART for OS. */ qupv3_se_fw_load_and_init(QUPV3_1_SE2, SE_PROTOCOL_UART, FIFO);