Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42498 )
Change subject: ACPI S3: Clean up resume path ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42498/1/src/arch/x86/acpi_s3.c File src/arch/x86/acpi_s3.c:
https://review.coreboot.org/c/coreboot/+/42498/1/src/arch/x86/acpi_s3.c@94 PS1, Line 94: die("Failed the jump to wakeup vector\n");
We could reset here instead, I think. Not sure if we have a generic reset though.
Ack
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c@174 PS1, Line 174: die("Failed OS resume\n");
If wake_vector above was lost for S3 resume path, we would not reach here but skip to BS_WRITE_TABLE […]
Ack