[coreboot-gerrit] Change in coreboot[master]: Chrome EC SOCs: Integrate Chrome EC check

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42258 )

Change subject: Chrome EC SOCs: Integrate Chrome EC check
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42258/2/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/42258/2/src/soc/amd/picasso/acpi.c@... 
PS2, Line 259: if (CONFIG(EC_GOOGLE_CHROMEEC)) {
             : 			gnvs->chromeos.vbt2 = google_ec_running_ro() ?
             : 				ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
             : 		} else {
             : 			gnvs->chromeos.vbt2 = ACTIVE_ECFW_RO;
             : 		}
> I think it would be better to move this to src/vendorcode/google/chromeos/gnvs. […]

Thank you for the suggestions.

The code is discussed in Ia6601bfd6e7a11eca6bbc32f6757c165ba5a4cff. Could you please comment there?

[1]: https://review.coreboot.org/c/coreboot/+/42201