[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add UPD settings to chip.h

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38699 )

Change subject: soc/amd/picasso: Add UPD settings to chip.h
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h 
File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h@... 
PS7, Line 36: 	/* Options for these are in src/arch/x86/include/arch/acpi.h */
Are all these really used by SoC and have to be provided by mainboard? Can we add them as required later on?