Hello Paul Menzel,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46015
to review the following change.
Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................
mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o
It was enabled by the vendor firmware.
Also drop spurious `io 0x60 = 0x00` setting. It's the default anyway and the resource is kept disabled (it's controlled by the virtual LDN 2e.008).
Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/46015/1
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index 3f9135c..aa21321 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -61,8 +61,9 @@ irq 0xf7 = 0x00 irq 0xf8 = 0x00 end - device pnp 2e.8 off # WDT1, GPIO0, GPIO1 - io 0x60 = 0x00 + device pnp 2e.008 off # WDT1 + end + device pnp 2e.108 on # GPIO0, GPIO1 irq 0xe0 = 0xff irq 0xe1 = 0xff irq 0xe2 = 0xff