Attention is currently required from: Patrick Rudolph, Johnny Lin, Paul Menzel, Christian Walter, Nill Ge, TangYiwei, Shelly Chang.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69310 )
Change subject: drivers/ipmi: Retry ipmi_get_device_id in ipmi_kcs_init
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69310/comment/e98e8486_030ea091
PS2, Line 11:
The IPMI handshaking w/ BMC still relies on retry for certain IPMI commands, especially this command […]
In addition to Johnny said, BMC does not reset during host warm reset and host DC cycle, so IPMI handshake will not be blocked for those two scenarios, and do not affect boot time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b972c905fb0f8223570212432a4a10bd715f3f7
Gerrit-Change-Number: 69310
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Thu, 10 Nov 2022 23:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment