Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48267 )
Change subject: sb/intel/common: Modify CONFIG_LOCK_MANAGEMENT_ENGINE behavior ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48267/1/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/48267/1/src/southbridge/intel/commo... PS1, Line 153: Kconfigprevents
Kconfig prevents
Ack
https://review.coreboot.org/c/coreboot/+/48267/2/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/48267/2/src/southbridge/intel/commo... PS2, Line 153: Kconfigprevents
space between Kconfig and prevents
Ack
https://review.coreboot.org/c/coreboot/+/48267/2/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48267/2/src/southbridge/intel/commo... PS2, Line 20: CONFIG_SOC_INTEL_CSE_LITE_SKU
In general, I think we avoid using SOC specific configs in more common code. […]
Ah, agree, modified the code accordingly.