Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: soc/intel/common/hda: Add HDA ID for Jasper Lake
......................................................................
Patch Set 2: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7
PS1, Line 7: support audio jack for Boten
Maybe your text from the commit message body: […]
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7
PS1, Line 7: src/
Please remove `src/` from the prefix.
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@9
PS1, Line 9: Add HDA ID for Jasperlake
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@13
PS1, Line 13: TEST=Add PCI ID to hda.c for boten
Maybe: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib62c332d8d87201b3e6903251d824e1c3e06cd68
Gerrit-Change-Number: 43441
Gerrit-PatchSet: 2
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yong Zhi
yong.zhi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 18:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment