Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34287/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34287/1//COMMIT_MSG@10 PS1, Line 10: shall
/s/shall/should ? […]
Ideally, one should only need to select their mainboard vendor and model (and a payload) to get a coreboot.rom that is able to boot. I am not sure if it's an actual requirement, but it makes lots of sense.
I thought FSP was included from 3rdparty/fsp by default, though?
https://review.coreboot.org/c/coreboot/+/34287/1/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/34287/1/src/soc/intel/cannonlake/Kc... PS1, Line 273:
@Furquan, I just checked and the only CNL users are Intel and Google boards, and all are selecting […]
This change is actually beneficial for these CNL boards.
It is changing the default option to what all the CNL boards in the (upstream) tree use, which should be tested and working :)