Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36081 )
Change subject: vc/amd/agesa/f16kb: Cast to UINT64 to avoid overflow
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36081/4/src/vendorcode/amd/agesa/f1...
File src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI/mfDMI.c:
https://review.coreboot.org/c/coreboot/+/36081/4/src/vendorcode/amd/agesa/f1...
PS4, Line 719: DctMemSize
I don't think a DTC on this platform manage 64G of dram, so you could add a sanity check instead of the cast?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f0aa26e116b47505633897c790ca8e86ea5dc4e
Gerrit-Change-Number: 36081
Gerrit-PatchSet: 4
Gerrit-Owner: awokd@danwin1210.me
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: awokd@danwin1210.me
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 20:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment