Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31773 )
Change subject: Add new CONFIG(XXX) macro to replace IS_ENABLED(CONFIG_XXX)
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
I'm ok with the change in concept. I'll note that because it touches so many files it's going to be a *LITTLE* disruptive to people working on private branches. That's the only issue I see.
Since IS_ENABLED is still supported, it's not really disruptive. With the other changes it's now a lint warning. After the next release (late April I guess) we can make it a lint error. That way only branches older than two months will run into it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2468427b569b974303084574125a9e1d9f6db596
Gerrit-Change-Number: 31773
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Mar 2019 08:35:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment