Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35030 )
Change subject: soc/intel/skylake: Add Lewisburg family PCH support ......................................................................
Patch Set 8:
(9 comments)
I'd say that the _PROD suffixes only make the code more verbose, but IMHO don't add important bits of information, since the production silicon is by far the most common case and the superset devices aren't really available. So I'd remove the _PROD, but keep the _SUPER
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 2717: _PROD I'd also drop the _PROD here and in the following lines
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 2805: _PROD same here and following
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 2951: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 2974: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 3080: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 3232: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 3243: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 3264: _PROD same
https://review.coreboot.org/c/coreboot/+/35030/8/src/include/device/pci_ids.... PS8, Line 3277: _PROD same