Attention is currently required from: Daniil Lunev, Subrata Banik, Wonkyu Kim, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Gwendal Grignou.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62662 )
Change subject: mb/intel/adlrvp: Enable UFS and ISH for ADL-N RVP
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62662/comment/1707d652_10971a21
PS1, Line 8:
Thank you. Maybe also say in the commit message, what UFS is.
Done that in the base patch, hope that works.
Commit Message:
https://review.coreboot.org/c/coreboot/+/62662/comment/3404b864_3288398c
PS4, Line 7: mb/intel/adlrvp: Enable UFS for ADL-N RVP
ISH should also be mentioned.
Done
https://review.coreboot.org/c/coreboot/+/62662/comment/a7088e50_23ea2d66
PS4, Line 12: Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com
Is this already tested? If so, please paste the excerpt from `lspci -t`.
Done
File src/mainboard/intel/adlrvp/devicetree_n.cb:
https://review.coreboot.org/c/coreboot/+/62662/comment/07a6a8af_5af56653
PS4, Line 288: device ref ufs on end
as discussed offline, the ufs node should have child "ref_clk" node with the appropriate frequency […]
Sure, will take this up in another CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If15bcaffc8fd3bbbe4b181820993ab2d882bbbe1
Gerrit-Change-Number: 62662
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniil Lunev
dlunev@chromium.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Gwendal Grignou
gwendal@chromium.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Daniil Lunev
dlunev@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Tue, 12 Apr 2022 07:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniil Lunev
dlunev@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment