Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Darren Ye has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )
Change subject: mb/google/rauru: Add 2nd source TAS2563 amps to support beep ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85360/comment/90b1c6c8_eba50bdd?usp... : PS3, Line 7: tas
TAS
Done
https://review.coreboot.org/c/coreboot/+/85360/comment/b3aa909c_9ab43a39?usp... : PS3, Line 9: Set 2nd source used i2s and i2c interface
Derive the audio amplifier from FW_CONFIG, and set up I2C and I2S for TAS2563. […]
Done
https://review.coreboot.org/c/coreboot/+/85360/comment/7b510b03_e147010c?usp... : PS3, Line 12: 357969183
b:357969183
Done
File src/mainboard/google/rauru/chromeos.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/b0183e38_5ad5be1e?usp... : PS3, Line 49: {
remove
Done
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/03dc7269_db3430dc?usp... : PS3, Line 31: printk(BIOS_INFO, "Audio configure.\n");
Move to the end of the function. and print […]
Done
https://review.coreboot.org/c/coreboot/+/85360/comment/facb3e24_bd7106d9?usp... : PS3, Line 33: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) { : return; : } else
Just remove.
Done