Attention is currently required from: Ashish Kumar Mishra, Jérémy Compostella, Paul Menzel, Sowmya Aralguppe, Wonkyu Kim.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83946?usp=email )
Change subject: soc/intel/common/block/cpu: Add Kconfig for effective way size for NEM+
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83946/comment/f332cec7_73e79609?usp... :
PS13, Line 28: 3
if one way size if 1.5MB (0x180000) then technically 3 way is enough to cover the mapping for 4.5MB (more than 4MB of CONFIG_DCACHE_RAM_SIZE)
I believe this effective way size calculation should be dependent of knowing if we are using LLC or MLC ? and if MLC then we need to use some other logic (may be what you have suggested) because MLC way size is always lesser than the LLC way size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83946?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5cb66da0aa977eecb64a0021268a6827747c521c
Gerrit-Change-Number: 83946
Gerrit-PatchSet: 13
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.corp-partner.google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 06 Sep 2024 19:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No