Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43862 )
Change subject: soc/intel/skylake: Enable eMMC depending on devicetree configuration
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43862/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43862/2/src/soc/intel/skylake/chip....
PS2, Line 257: ScsEmmcHs400Enabled
I don't have the source code of the FSP, but I would say so. However, this change is not intended to change the logic of this.
ack, we can revisit that later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b86ff6e2f15991fb304b71d90c1b959cb6fcf43
Gerrit-Change-Number: 43862
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment