Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG@26
PS5, Line 26: Adding these 3 config will allow user to add one more vbt file
What happens when a 3rd VBT file is required? In general I don't think it is correct to keep adding […]
Exactly what Furquan said, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... for an example, where we choose at runtime which VBT file to load from the CBFS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905
Gerrit-Change-Number: 48205
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 18:56:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment