Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47580 )
Change subject: soc/amd/picasso/include: unify include guards
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47580/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47580/1//COMMIT_MSG@7
PS1, Line 7: coreboot style
Is this documented? Doing a quick spot check, it seems like there are all types of styles currently […]
oh, had a closer look and there are indeed instances of double underscore style include guards outside of src/vendorcode, so I dropped the "coreboot style" from the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I980cdd03d4283cd4bd9db8bd90fde9a43bebc1e5
Gerrit-Change-Number: 47580
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 15 Nov 2020 17:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment