Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36844 )
Change subject: security/vboot: Remove buffer_size from struct vboot_working_data
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c...
PS1, Line 80: size
No need for a temporary variable here. In fact, actually introduces the bug that I was previously encountering, since uint16_t is too small for this number.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie770e89b4a45e0ec703d5bbb8fb6a298ce915056
Gerrit-Change-Number: 36844
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 10:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment