Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62637 )
Change subject: ec/starlabs/merlin: Use ECWR function ......................................................................
ec/starlabs/merlin: Use ECWR function
Use ECWR function, instead of writing raw values to emem, to avoid a lack of syncronisation as it uses a mutex.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I90cfd3e1752fe25493bd72ea6bcab1fd9318d2e3 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/62637/1
diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index 4532f10..bfa6a07 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -81,11 +81,11 @@ // 0x01 == Disabled == 0x22 Case (0x00) { - _SB.PCI0.LPCB.EC.TPLE = 0x00 + ECWR (0x00, TPLE) } Case (0x01) { - _SB.PCI0.LPCB.EC.TPLE = 0x22 + ECWR (0x22, TPLE) } }
@@ -97,11 +97,11 @@ // 0x01 == Enabled == 0xdd Case (0x00) { - _SB.PCI0.LPCB.EC.KLSE = 0x00 + ECWR (0x00, KLSE) } Case (0x01) { - _SB.PCI0.LPCB.EC.KLSE = 0xdd + ECWR (0xdd, KLSE) } }
@@ -113,19 +113,19 @@ // 0x03 == High == 0xaa Case (0x00) { - _SB.PCI0.LPCB.EC.KLBE 0xdd + ECWR (0xdd, KLBE) } Case (0x01) { - _SB.PCI0.LPCB.EC.KLBE = 0xcc + ECWR (0xdd, KLBE) } Case (0x02) { - _SB.PCI0.LPCB.EC.KLBE = 0xbb + ECWR (0xbb, KLBE) } Case (0x03) { - _SB.PCI0.LPCB.EC.KLBE = 0xaa + ECWR (0xaa, KLBE) } } }