29 Nov
2021
29 Nov
'21
8:23 p.m.
Attention is currently required from: Tim Wawrzynczak, Julius Werner, Patrick Rudolph. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59679 )
Change subject: intel: cse_lite: Use cbfs_unverified_area API ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59679/comment/dab98cef_a559cee8 PS2, Line 676: cbfs_unverified_area_map I wonder if anyone even noticed this was insecure when it was first written.
Tim, What's preventing the CSE firmware from moving into FW_MAIN_A/B? IMO, we should fix this instead of having a special CBFS API for this use case.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4855280d6d06cf1aa646fded916fd830b287b30
Gerrit-Change-Number: 59679
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 29 Nov 2021 19:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment