Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34369 )
Change subject: soc/amd/common: Skip S3 save/restore related function calls if !HAVE_ACPI_RESUME
......................................................................
Patch Set 5:
Patch Set 5: Code-Review-1
There are empty stubs in stage_cache.h for the case with cache disabled, no need for the extra
guards here.
Further comments in CB:31490
i'm happy to abandon this CL. Kindly consider my CB:33116 is now dependent on your CL CB:31490
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620429d05f924b457d7d1b34fc242a621f273191
Gerrit-Change-Number: 34369
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 04:28:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment