Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33362 )
Change subject: vendorcode/amd/agesa/{f12,f14,f15tn,f16kb} PcieConfigLib.c: Fix logical 'or' of equal expressions
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33362/2/src/vendorcode/amd/agesa/f12/Proc/GN...
File src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbPcieConfig/PcieConfigLib.c:
https://review.coreboot.org/#/c/33362/2/src/vendorcode/amd/agesa/f12/Proc/GN...
PS2, Line 205:
The second test here should be for Engine->EngineData.EndLane
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia04ac5b1d0a4434c0ab2ca583b9b03dbfd0ffd41
Gerrit-Change-Number: 33362
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Jun 2019 23:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment