Attention is currently required from: Hannah Williams, Jamie Ryu, Kapil Porwal, Subrata Banik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76123?usp=email )
Change subject: intel/common/block/cpu: add cpu clock measure api
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/76123/comment/8a643497_254acd02 :
PS3, Line 527: udelay(100);
Need to be careful about static delay if we are going to call this function multiple times.
Agreed. This function will be used early time for checking different silicon SKU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76123?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd6483e0be5c48fc3da2227b979882b394429c4
Gerrit-Change-Number: 76123
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 18:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment