Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Shuo Liu, yuchi.chen@intel.com.
Vasiliy Khoruzhick has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/snowridge/memmap.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/b144e6e7_a6682372?usp... :
PS14, Line 10: return soc_systemagent_fixup_address(
You need to #include <intelblocks/systemagent.h> to call soc_systemagent_fixup_address() here, otherwise it results in implicit declaration warning (or error if compiled with -Werror)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 14
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 19 Aug 2024 23:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No