Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29872 )
Change subject: mb/poppy/variant/nami: Move FPMCU_INT_L gpios to B group
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nami/gpio.c:
https://review.coreboot.org/#/c/29872/2/src/mainboard/google/poppy/variants/...
PS2, Line 413: PAD_CFG_GPI_APIC
Did you try PAD_CFG_GPI_APIC_INVERT?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2332b0eb7a2f74e8178b95a23c8ac2091027a071
Gerrit-Change-Number: 29872
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 28 Nov 2018 05:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment