Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shon Wang, Subrata Banik.
Sumeet R Pawnikar has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83302?usp=email )
Change subject: mb/google/brask/var/bujia: Hook up two missing sensors for wireless and memory
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83302/comment/93074cd5_ba56cbda?usp... :
PS4, Line 12: 327549688
Please add me in the bug to go through the history on this. Thanks.
File src/mainboard/google/brya/variants/bujia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83302/comment/6d76ff4c_580ce1aa?usp... :
PS4, Line 86: CHARGER
Any reason for removing Charger control (throttling input charging current) in new code change?
https://review.coreboot.org/c/coreboot/+/83302/comment/7e03ee7b_b18ca870?usp... :
PS4, Line 66: CPU
Any reason for changing the sensor0 name from DRAM to CPU? We have DPTF_CPU available and used in active policy below at line #75.
Also, same question for sensor1 name change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83302?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id9a17a22a717faac829e6b5e300351187a62dd43
Gerrit-Change-Number: 83302
Gerrit-PatchSet: 4
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 10:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No