[coreboot-gerrit] Change in coreboot[master]: vendorcode/google/chromeos: Introduce helper for CSE board reset

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44646 )

Change subject: vendorcode/google/chromeos: Introduce helper for CSE board reset
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44646/3/src/vendorcode/google/chrom... 
File src/vendorcode/google/chromeos/cse_board_reset.c:

https://review.coreboot.org/c/coreboot/+/44646/3/src/vendorcode/google/chrom... 
PS3, Line 14: FULL_RST | SYS_RST
> Just setting the 4th bit is sufficient in the coreboot. […]

@Sridhar, I will check with that and upload a follow-up patch.

@Edward, EC commands have a longer latency than 50 us and we are using that for the command to 0xcf9 to settle down.

@Furquan, Added the comment as required.

https://review.coreboot.org/c/coreboot/+/44646/3/src/vendorcode/google/chrom... 
PS3, Line 15: if (!google_chromeec_ap_reset())
> Sorry, I forgot to add in the last review that we should perhaps do a version check here now that is […]

Done