Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83508?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for PMC ......................................................................
device/pci_ids: Add new Intel PTL device IDs for PMC
This patch adds new PMC PCI device IDs for Intel PTL-U and PTL-H.
Additionally, updates the PMC driver's `pci_device_ids` list to include these new IDs.
Source: Intel PTL-EDS vol 1. Document Number 815002, Rev 0.51 Chapter 2
BUG=b:347669091 TEST=Able to build google/fatcat.
Change-Id: Iae468fdace2d9cfd532957e4f3c55b89b96a52a0 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83508 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/pmc/pmc.c 2 files changed, 4 insertions(+), 2 deletions(-)
Approvals: Angel Pons: Looks good to me, but someone else must approve build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c4fa842..c7b875c 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3767,7 +3767,8 @@ #define PCI_DID_INTEL_RPP_P_PMC 0x51a1 #define PCI_DID_INTEL_RPP_S_PMC 0x7a21 #define PCI_DID_INTEL_LNL_PMC 0xa821 -#define PCI_DID_INTEL_PTL_PMC 0xe421 +#define PCI_DID_INTEL_PTL_H_PMC 0xe421 +#define PCI_DID_INTEL_PTL_U_H_PMC 0xe321
/* Intel I2C device Ids */ #define PCI_DID_INTEL_LPT_LP_I2C0 0x9c61 diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index bc70b1a..ca1c4b0 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -111,7 +111,8 @@ };
static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_PTL_PMC, + PCI_DID_INTEL_PTL_H_PMC, + PCI_DID_INTEL_PTL_U_H_PMC, PCI_DID_INTEL_LNL_PMC, PCI_DID_INTEL_MTL_SOC_PMC, PCI_DID_INTEL_MTL_IOE_M_PMC,